TimeAdd supports DayTimeIntervalType #3507
Conversation
Signed-off-by: Bobby Wang <wbo4958@gmail.com>
|
build |
| case class GpuTimeAdd(start: Expression, | ||
| interval: Expression, | ||
| timeZoneId: Option[String] = None) | ||
| extends GpuTimeMath(start, interval, timeZoneId) { |
There was a problem hiding this comment.
nit: It is a little odd to use GpuTimeMath here when we override essentially all of it.
|
build |
| @@ -0,0 +1,36 @@ | |||
| /* | |||
| * Copyright (c) 2021, NVIDIA CORPORATION. | |||
There was a problem hiding this comment.
this file has . in the name of it change to directories
| override def left: Expression = start | ||
| override def right: Expression = interval | ||
|
|
||
| override def toString: String = s"$left - $right" |
There was a problem hiding this comment.
nit: This is probably a bug in GpuTimeAdd for the older code too, but this should be a + not a -. This goes for sql too.
There was a problem hiding this comment.
Thx @revans2 , I'd like to merge this PR first, and file a following PR for this, since this PR is blocking my following Range window PR.
|
@wbo4958 my comment wa snot addressed, please put up PR to fix file name main/301until320-all/scala/org/apache/spark/sql/rapids.shims.v2/datetimeExpressions.scala |
Thx Tom, My bad. really sorry for that. I just had a PR for this. |
This PR is to fix #3502 by adding DayTimeIntervalType support for TimeAdd.
Tested date_time_test.py against spark 3.2.0, and pass
BTW, This RP didn't add DayTimeIntervalType support for TimeSub since it has been deleted from Spark 3.1