Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Provide an explicit config for fallback on CPU if plan rewrite fails #3739

Closed
gerashegalov opened this issue Oct 1, 2021 · 0 comments · Fixed by #3963
Closed

[FEA] Provide an explicit config for fallback on CPU if plan rewrite fails #3739

gerashegalov opened this issue Oct 1, 2021 · 0 comments · Fixed by #3963
Assignees
@gerashegalov
Labels
feature request New feature or request P0 Must have for release
Milestone
Oct 18 - Oct 29

Comments

@gerashegalov
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
In #3711 we rely on spark.rapids.sql.test.enabled to control whether we throw an exception or just log it and fall back on CPU if the GpuOverrides application fails

Describe the solution you'd like
Provide an explicit switch to control this behavior

Describe alternatives you've considered

  • always fail
  • always fallback
  • rely on test.enabled as a switch

Additional context
#3711 (comment)
@gerashegalov gerashegalov added feature request New feature or request ? - Needs Triage Need team to review and classify labels Oct 1, 2021
@sameerz sameerz added P0 Must have for release and removed ? - Needs Triage Need team to review and classify labels Oct 5, 2021
@gerashegalov gerashegalov added this to the Oct 18 - Oct 29 milestone Oct 28, 2021
@gerashegalov gerashegalov mentioned this issue Oct 28, 2021
Merged
gerashegalov added a commit that referenced this issue Oct 29, 2021
@gerashegalov
Add a dedicated RapidsConf option to tolerate GpuOverrides apply fail…
17500a5 
…ures (#3963)

This PR provides an option to tolerate GPU plan override failures (off by default) without having to toggle spark.rapids.sql.enabled before and after a problematic query.

Closes #3739 

Signed-off-by: Gera Shegalov <gera@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gerashegalov gerashegalov

Labels
feature request New feature or request P0 Must have for release
Projects
None yet
Milestone
Oct 18 - Oct 29
Development

Successfully merging a pull request may close this issue.

Add a dedicated RapidsConf option to tolerate GpuOverrides apply failures gerashegalov/spark-rapids
2 participants
@gerashegalov @sameerz