Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit the default value set in spark_session.py for improvedFloatOps conf in integration tests #5844

Closed
razajafri opened this issue Jun 15, 2022 · 1 comment
Closed

Revisit the default value set in spark_session.py for improvedFloatOps conf in integration tests #5844

razajafri opened this issue Jun 15, 2022 · 1 comment
Assignees
@razajafri
Labels
P0 Must have for release test Only impacts tests

Comments

@razajafri
Copy link
Collaborator

As part of #5441 default confs were changed.

We should revisit the integration tests to make sure the default confs are set to the values we want in each of the tests where it's relevant.

Originally posted by @tgravescs in #5840 (comment)
@razajafri razajafri mentioned this issue Jun 15, 2022
Merged
@sameerz sameerz added ? - Needs Triage Need team to review and classify test Only impacts tests P0 Must have for release and removed ? - Needs Triage Need team to review and classify labels Jun 17, 2022
@razajafri razajafri self-assigned this Jul 8, 2022
@razajafri razajafri changed the title Revisit the default confs in integration tests Revisit tests that are using improvedFloatOps conf in integration tests Jul 8, 2022
@razajafri
Copy link
Collaborator Author

razajafri commented Jul 12, 2022 •
edited
Loading

We shouldn't change the value we set in spark_session.py for improvedFloatOps as the results of operations after we set the improvedFloatOps to true, won't match the Spark results.

Edit: So even though we have changed the default value of improvedFloatOps in the RapidsConf to true, the tests should still test with the value of false because we are testing to match the Spark results

@razajafri razajafri changed the title Revisit tests that are using improvedFloatOps conf in integration tests Revisit the default value set in spark_session.py for improvedFloatOps conf in integration tests Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@razajafri razajafri

Labels
P0 Must have for release test Only impacts tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sameerz @razajafri