[DOC] Updated RapidsConf to reflect the default value of spark.rapids.sql.improvedFloatOps.enabled [skip ci]
#5840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
|
please put better description then updated docs |
tgravescs
reviewed
Jun 15, 2022
| @@ -575,8 +575,7 @@ object RapidsConf { | |||
| val IMPROVED_FLOAT_OPS = conf("spark.rapids.sql.improvedFloatOps.enabled") | |||
| .doc("For some floating point operations spark uses one way to compute the value " + | |||
| "and the underlying cudf implementation can use an improved algorithm. " + | |||
| "In some cases this can result in cudf producing an answer when spark overflows. " + | |||
| "Because this is not as compatible with spark, we have it disabled by default.") | |||
| "In some cases this can result in cudf producing an answer when spark overflows.") | |||
| .booleanConf | |||
| .createWithDefault(true) | |||
There was a problem hiding this comment.
we intentionally put the confs into our integration test with the defaults they had, if we change the default here those tests I believe should be updated as well...
integration_tests/src/main/python/spark_session.py:
'spark.rapids.sql.improvedFloatOps.enabled': 'false',
Can you please file a 22.08 issue to update those tests. We may want to check other defualtas as well
There was a problem hiding this comment.
created issue #5844
|
build |
razajafri
changed the title
spark.rapids.sql.improvedFloatOps.enabled [skip ci]
tgravescs
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
spark.rapids.sql.improvedFloatOps.enabledis not disabled by default.This PR updates the RapidsConf to reflect that.
Signed-off-by: Raza Jafri rjafri@nvidia.com