-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating documentation for data format support #2086
Updating documentation for data format support #2086
Conversation
Signed-off-by: Sameer Raheja <sraheja@nvidia.com>
Actually, that isn't correct. @viadea was using an unsupported format, not a format that can produce incorrect results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@andygrove is it still accurate to say that "some are supported but can produce incorrect results for invalid inputs" or should I update the document? |
@andygrove is going to investigate |
…nto branch-0.5-doc-date-formats
Signed-off-by: Sameer Raheja <sraheja@nvidia.com>
@andygrove please re-review |
build |
1 similar comment
build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Sameer. I think this is much clearer now.
* Updating documentation for data format support Signed-off-by: Sameer Raheja <sraheja@nvidia.com> * Update config docs to reflect compatibility doc update Signed-off-by: Sameer Raheja <sraheja@nvidia.com>
* Updating documentation for data format support Signed-off-by: Sameer Raheja <sraheja@nvidia.com> * Update config docs to reflect compatibility doc update Signed-off-by: Sameer Raheja <sraheja@nvidia.com>
This is a first pass at updating the documentation to warn users about unsupported data formats.
@andygrove if we have any more specific information about which formats are supported but can produce incorrect results for invalid inputs, it would be good for us to clarify that in the docs as well.
Fixes #2003