-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore hash partitioning of arrays #2347
Conversation
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did we have any specific tests for this?
Yes, they were added when the support was disabled to prove that we weren't calling through cudf otherwise the tests would fail. Which reminds me, I need to remove the exclusions on shuffle that @revans2 added recently for those tests. |
build |
CI failed waiting for #2271 to update to recent cudf change. |
build |
build |
* Restore hash partitioning of arrays Signed-off-by: Jason Lowe <jlowe@nvidia.com> * Remove test workarounds for disabled hash partitioning of arrays
* Restore hash partitioning of arrays Signed-off-by: Jason Lowe <jlowe@nvidia.com> * Remove test workarounds for disabled hash partitioning of arrays
Fixes #2330
Now that rapidsai/cudf#8098 has been fixed, this restores support for hash partitioning for arrays that was removed in #2319.