Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore hash partitioning of arrays #2347

Merged
merged 2 commits into from
May 6, 2021

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented May 5, 2021

Fixes #2330

Now that rapidsai/cudf#8098 has been fixed, this restores support for hash partitioning for arrays that was removed in #2319.

Signed-off-by: Jason Lowe <jlowe@nvidia.com>
@jlowe jlowe added this to the Apr 26 - May 7 milestone May 5, 2021
@jlowe jlowe self-assigned this May 5, 2021
@jlowe
Copy link
Member Author

jlowe commented May 5, 2021

build

tgravescs
tgravescs previously approved these changes May 6, 2021
Copy link
Collaborator

@tgravescs tgravescs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did we have any specific tests for this?

@jlowe
Copy link
Member Author

jlowe commented May 6, 2021

did we have any specific tests for this?

Yes, they were added when the support was disabled to prove that we weren't calling through cudf otherwise the tests would fail. Which reminds me, I need to remove the exclusions on shuffle that @revans2 added recently for those tests.

@jlowe
Copy link
Member Author

jlowe commented May 6, 2021

build

@jlowe
Copy link
Member Author

jlowe commented May 6, 2021

CI failed waiting for #2271 to update to recent cudf change.

@abellina
Copy link
Collaborator

abellina commented May 6, 2021

build

@jlowe
Copy link
Member Author

jlowe commented May 6, 2021

build

@jlowe jlowe merged commit bddfe2f into NVIDIA:branch-0.6 May 6, 2021
@jlowe jlowe deleted the restore-hash-partition-arrays branch May 6, 2021 22:42
@sameerz sameerz added the task Work required that improves the product but is not user facing label May 10, 2021
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
* Restore hash partitioning of arrays

Signed-off-by: Jason Lowe <jlowe@nvidia.com>

* Remove test workarounds for disabled hash partitioning of arrays
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
* Restore hash partitioning of arrays

Signed-off-by: Jason Lowe <jlowe@nvidia.com>

* Remove test workarounds for disabled hash partitioning of arrays
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Work required that improves the product but is not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Enable hash partitioning with arrays
5 participants