CaseWhen supports ArrayType
#2388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
firestarman
changed the title
CaseWhen supports ArrayTypeCaseWhen supports ArrayType [Small PR]
firestarman
changed the title
CaseWhen supports ArrayType [Small PR]CaseWhen supports ArrayType
|
build |
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
|
build |
revans2
reviewed
May 11, 2021
There was a problem hiding this comment.
Could you please file follow on issues for the other operations that we probably can support for single level arrays now too.
GpuIfwhich should allow you to testnvl2because it is implemented in terms ofif. (alsonullif, but needs support for a null literal array, so we might need a separate issue for this one).GpuColaescewhich should allow you to testnvlandifnullbecause they are implemented in terms ofcoalesce
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
Here it is #2398 |
|
build |
1 similar comment
|
build |
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
|
build |
revans2
approved these changes
May 12, 2021
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add
ArrayTypesupport to the expressionCaseWhen. Since the cudf has supported it by the PR rapidsai/cudf#8135 .Closed #1996
Signed-off-by: Firestarman firestarmanllc@gmail.com