Filter out the nulls after slicing the batches. #2447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
wbo4958
reviewed
May 19, 2021
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuPartitioning.scala
Outdated
Show resolved
Hide resolved
|
build |
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
|
build |
This reverts commit a63c85a.
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
|
build |
|
I converted the PR to draft, because I am not sure whether the linked bug is reproduceable on branch-21.06 (it was 0.6 before), which is the base branch of the PR. I tried several times locally but can not get the NPE. |
revans2
approved these changes
May 19, 2021
jlowe
approved these changes
May 19, 2021
|
Thanks @viadea for the verification on branch-21.06. |
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Filter out the nulls after slicing the batches. Signed-off-by: Firestarman <firestarmanllc@gmail.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Filter out the nulls after slicing the batches. Signed-off-by: Firestarman <firestarmanllc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix the NPE in
GpuShuffleExchangeby filtering out the nulls after slicing the batches forGpuRangePartitionerandGpuSinglePartitioning. Just like what theGpuHashPartitioningdoes here.The root cause of this NPE is the batch array returned from the method sliceInternalGpuOrCpu may contain nulls that generated by the function 'sliceBatch' for the corner case of empty batch (row number is 0). So even a single batch is expected, we still need to filter out the null.
Closes #2421
Signed-off-by: Firestarman firestarmanllc@gmail.com