align GDS reads/writes to 4 KiB #2460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rong Ou <rong.ou@gmail.com>
Signed-off-by: Rong Ou <rong.ou@gmail.com>
rongou
added
performance
jlowe
reviewed
May 20, 2021
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RapidsGdsStore.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Rong Ou <rong.ou@gmail.com>
jlowe
previously approved these changes
May 21, 2021
|
build |
Signed-off-by: Rong Ou <rong.ou@gmail.com>
revans2
previously approved these changes
May 24, 2021
jlowe
reviewed
May 24, 2021
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RapidsGdsStore.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Rong Ou <rong.ou@gmail.com>
Signed-off-by: Rong Ou <rong.ou@gmail.com>
jlowe
previously approved these changes
May 26, 2021
rongou
changed the title
|
Still doing some tweaking and testing, changed to WIP for now. |
Signed-off-by: Rong Ou <rong.ou@gmail.com>
rongou
changed the title
|
build |
1 similar comment
|
build |
jlowe
approved these changes
Jun 2, 2021
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* align GDS reads/writes to 4 KiB Signed-off-by: Rong Ou <rong.ou@gmail.com> * extract variable Signed-off-by: Rong Ou <rong.ou@gmail.com> * add comments for alignment Signed-off-by: Rong Ou <rong.ou@gmail.com> * add unaligned fallback Signed-off-by: Rong Ou <rong.ou@gmail.com> * turn off aligned with copyToMemoryBuffer() Signed-off-by: Rong Ou <rong.ou@gmail.com> * add option to turn off aligned IO Signed-off-by: Rong Ou <rong.ou@gmail.com> * add config for alignment threshold Signed-off-by: Rong Ou <rong.ou@gmail.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* align GDS reads/writes to 4 KiB Signed-off-by: Rong Ou <rong.ou@gmail.com> * extract variable Signed-off-by: Rong Ou <rong.ou@gmail.com> * add comments for alignment Signed-off-by: Rong Ou <rong.ou@gmail.com> * add unaligned fallback Signed-off-by: Rong Ou <rong.ou@gmail.com> * turn off aligned with copyToMemoryBuffer() Signed-off-by: Rong Ou <rong.ou@gmail.com> * add option to turn off aligned IO Signed-off-by: Rong Ou <rong.ou@gmail.com> * add config for alignment threshold Signed-off-by: Rong Ou <rong.ou@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on rapidsai/cudf#8301.
Signed-off-by: Rong Ou rong.ou@gmail.com