Fix for UCP Listener created spark.port.maxRetries times #2476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
abellina
added
bug
|
@petro-rudenko fyi |
jlowe
previously approved these changes
May 21, 2021
shuffle-plugin/src/main/scala/com/nvidia/spark/rapids/shuffle/ucx/UCX.scala
Outdated
Show resolved
Hide resolved
jlowe
approved these changes
May 21, 2021
|
build |
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Fix for UCP Listener created spark.port.maxRetries times Signed-off-by: Alessandro Bellina <abellina@nvidia.com> * Update attempt earlier to remove need fix in log
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Fix for UCP Listener created spark.port.maxRetries times Signed-off-by: Alessandro Bellina <abellina@nvidia.com> * Update attempt earlier to remove need fix in log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alessandro Bellina abellina@nvidia.com
Closes #2474
This bug shows when the UCP listener connection method is enabled (this is an internal config, and is disabled by default). It was just connecting up to all the retry attempts, instead of exiting once the listener could bind.