Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve window agg test for range numeric types #2493

Merged
merged 1 commit into from
May 25, 2021

Conversation

wbo4958
Copy link
Collaborator

@wbo4958 wbo4958 commented May 24, 2021

This change makes the partition-by column to be repeatable

Signed-off-by: Bobby Wang wbo4958@gmail.com

This change makes the partition-by column to be repeatable

Signed-off-by: Bobby Wang <wbo4958@gmail.com>
@wbo4958 wbo4958 added test Only impacts tests and removed test Only impacts tests labels May 24, 2021
@wbo4958
Copy link
Collaborator Author

wbo4958 commented May 24, 2021

build

Copy link
Collaborator

@wjxiz1992 wjxiz1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
nit: could put the important explanation in description body.

@wbo4958 wbo4958 merged commit 5986fc3 into NVIDIA:branch-21.06 May 25, 2021
@wbo4958 wbo4958 deleted the range-numeric-test branch May 25, 2021 04:06
@sameerz sameerz added the test Only impacts tests label May 27, 2021
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
This change makes the partition-by column to be repeatable

Signed-off-by: Bobby Wang <wbo4958@gmail.com>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
This change makes the partition-by column to be repeatable

Signed-off-by: Bobby Wang <wbo4958@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants