Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fetchTime and standardize on collectTime #2515

Merged
merged 1 commit into from
Jun 3, 2021
Merged

Remove fetchTime and standardize on collectTime #2515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuColumnarToRowExec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,16 +281,16 @@ abstract class GpuColumnarToRowExecParent(child: SparkPlan, val exportColumnarRd
override lazy val allMetrics: Map[String, GpuMetric] = Map(
NUM_OUTPUT_ROWS -> createMetric(outputRowsLevel, DESCRIPTION_NUM_OUTPUT_ROWS),
OP_TIME -> createNanoTimingMetric(MODERATE_LEVEL, DESCRIPTION_OP_TIME),
FETCH_TIME -> createNanoTimingMetric(MODERATE_LEVEL, DESCRIPTION_FETCH_TIME),
COLLECT_TIME -> createNanoTimingMetric(MODERATE_LEVEL, DESCRIPTION_COLLECT_TIME),
NUM_INPUT_BATCHES -> createMetric(DEBUG_LEVEL, DESCRIPTION_NUM_INPUT_BATCHES))

override def doExecute(): RDD[InternalRow] = {
val numOutputRows = gpuLongMetric(NUM_OUTPUT_ROWS)
val numInputBatches = gpuLongMetric(NUM_INPUT_BATCHES)
val opTime = gpuLongMetric(OP_TIME)
val fetchTime = gpuLongMetric(FETCH_TIME)
val collectTime = gpuLongMetric(COLLECT_TIME)

val f = makeIteratorFunc(child.output, numOutputRows, numInputBatches, opTime, fetchTime)
val f = makeIteratorFunc(child.output, numOutputRows, numInputBatches, opTime, collectTime)

val cdata = child.executeColumnar()
if (exportColumnarRdd) {
Expand Down
2 changes: 0 additions & 2 deletions sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuExec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ object GpuMetric extends Logging {
val NUM_PARTITIONS = "numPartitions"
val TOTAL_TIME = "totalTime"
val OP_TIME = "opTime"
val FETCH_TIME = "fetchTime"
val PEAK_DEVICE_MEMORY = "peakDevMemory"
val COLLECT_TIME = "collectTime"
val CONCAT_TIME = "concatTime"
Expand All @@ -76,7 +75,6 @@ object GpuMetric extends Logging {
val DESCRIPTION_NUM_PARTITIONS = "partitions"
val DESCRIPTION_TOTAL_TIME = "total time"
val DESCRIPTION_OP_TIME = "op time"
val DESCRIPTION_FETCH_TIME = "fetch time"
val DESCRIPTION_PEAK_DEVICE_MEMORY = "peak device memory"
val DESCRIPTION_COLLECT_TIME = "collect batch time"
val DESCRIPTION_CONCAT_TIME = "concat batch time"
Expand Down