Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve debug print to include addresses and null counts #2526

Merged
merged 1 commit into from
May 27, 2021

Conversation

revans2
Copy link
Collaborator

@revans2 revans2 commented May 27, 2021

When helping to debug a recent issue I ran into a problem where it was not simple to know if a column had no nulls in it and no validity buffer or no nulls and it has a validity buffer. This helps to debug those cases by adding that info to the debug methods.

Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
@revans2 revans2 added the test Only impacts tests label May 27, 2021
@revans2 revans2 added this to the May 24 - Jun 4 milestone May 27, 2021
@revans2 revans2 self-assigned this May 27, 2021
@revans2
Copy link
Collaborator Author

revans2 commented May 27, 2021

build

@revans2 revans2 merged commit 3da9ba9 into NVIDIA:branch-21.06 May 27, 2021
@revans2 revans2 deleted the improve_debug branch May 27, 2021 15:48
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants