date_format should not suggest enabling incompatibleDateFormats for formats we cannot support #2532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
changed the title
wjxiz1992
reviewed
May 28, 2021
| assert_gpu_and_cpu_are_equal_collect( | ||
| lambda spark : unary_op_df(spark, data_gen).selectExpr("date_format(a, '{}')".format(date_format))) | ||
|
|
||
| unsupported_date_formats_force = ['F'] |
There was a problem hiding this comment.
This seems to be duplicated?
There was a problem hiding this comment.
The second version of the test specifies conf = {"spark.rapids.sql.incompatibleDateFormats.enabled": "true"}
There was a problem hiding this comment.
Oh, sorry, I mean the variable unsupported_date_formats_force is assigned but not used.
There was a problem hiding this comment.
Thanks, this is fixed now. There were numerous other issues with the tests that are also resolved now.
| assert_gpu_and_cpu_are_equal_collect( | ||
| lambda spark : unary_op_df(spark, data_gen).selectExpr("date_format(a, '{}')".format(date_format))) | ||
|
|
||
| maybe_supported_date_formats_force = ['dd-MM-yyyy'] |
revans2
reviewed
Jun 2, 2021
|
build |
|
@revans2 @wjxiz1992 Let me know if any more changes are needed |
|
@andygrove can we retarget this to 21.08? |
revans2
previously approved these changes
Jun 7, 2021
|
Moving to branch-21.08 after @Salonijain27 confirmed with the PR author. |
revans2
previously approved these changes
Jun 9, 2021
andygrove
requested review from
GaryShen2008,
jlowe,
NvTimLiu and
tgravescs
as code owners
…ormats we cannot support Signed-off-by: Andy Grove <andygrove@nvidia.com>
andygrove
force-pushed
the
date-fmt-compat
branch
from
50af85a to
4e61791
Compare
revans2
approved these changes
Jun 21, 2021
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andy Grove andygrove@nvidia.com
Closes #2517.