Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed code indentation in ParquetCachedBatchSerializer #2538

Merged
merged 2 commits into from
Jun 2, 2021
Merged

Fixed code indentation in ParquetCachedBatchSerializer #2538

merged 2 commits into from
Jun 2, 2021

Conversation

razajafri
Copy link
Collaborator

Signed-off-by: Raza Jafri rjafri@nvidia.com

@razajafri
fixed indentation
cc8ec6e 
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
@razajafri razajafri marked this pull request as draft May 28, 2021 21:55
@razajafri razajafri mentioned this pull request May 28, 2021
Closed
@razajafri razajafri added the task Work required that improves the product but is not user facing label May 28, 2021
@razajafri @jlowe
Update shims/spark311/src/main/scala/com/nvidia/spark/rapids/shims/sp…
0d84cc9 
…ark311/ParquetCachedBatchSerializer.scala

Co-authored-by: Jason Lowe <jlowe@nvidia.com>
@razajafri razajafri requested a review from jlowe June 2, 2021 16:20
jlowe
jlowe approved these changes Jun 2, 2021
View reviewed changes
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed this is a draft PR, but there's no comment explaining why?

@jlowe jlowe changed the title Fixed Indentation Fixed code indentation in ParquetCachedBatchSerializer Jun 2, 2021
@razajafri
Copy link
Collaborator Author

I had made it a draft because of #2459 PR. But now that I have to rework #2459. Its fine for this to go in first, I will change it

@razajafri razajafri marked this pull request as ready for review June 2, 2021 16:43
@razajafri
Copy link
Collaborator Author

build

@jlowe jlowe merged commit 769a788 into NVIDIA:branch-21.06 Jun 2, 2021
@razajafri razajafri deleted the fix-indentation branch June 2, 2021 22:32
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
@razajafri @jlowe
Fixed code indentation in ParquetCachedBatchSerializer (NVIDIA#2538)
afda4ab 
* fixed indentation

Signed-off-by: Raza Jafri <rjafri@nvidia.com>

* Update shims/spark311/src/main/scala/com/nvidia/spark/rapids/shims/spark311/ParquetCachedBatchSerializer.scala

Co-authored-by: Jason Lowe <jlowe@nvidia.com>

Co-authored-by: Raza Jafri <rjafri@nvidia.com>
Co-authored-by: Jason Lowe <jlowe@nvidia.com>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
@razajafri @jlowe
Fixed code indentation in ParquetCachedBatchSerializer (NVIDIA#2538)
4dbbe31 
* fixed indentation

Signed-off-by: Raza Jafri <rjafri@nvidia.com>

* Update shims/spark311/src/main/scala/com/nvidia/spark/rapids/shims/spark311/ParquetCachedBatchSerializer.scala

Co-authored-by: Jason Lowe <jlowe@nvidia.com>

Co-authored-by: Raza Jafri <rjafri@nvidia.com>
Co-authored-by: Jason Lowe <jlowe@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

Assignees
No one assigned
Labels
task Work required that improves the product but is not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@razajafri @jlowe