support collect_set in rolling window #2548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revans2
reviewed
Jun 1, 2021
There was a problem hiding this comment.
Just a few nits, but I don't think this is going to get in to 21.06 because it depends on things in cudf that are still pending, and cudf 21.06 is frozen. If we are going to keep this targeted here we are going to need @sameerz to work with the cudf team to get the remaining dependencies in.
firestarman
reviewed
Jun 2, 2021
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/AggregateFunctions.scala
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/AggregateFunctions.scala
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/AggregateFunctions.scala
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/AggregateFunctions.scala
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/AggregateFunctions.scala
Show resolved
Hide resolved
revans2
reviewed
Jun 2, 2021
|
LGTM |
sperlingxx
changed the title
|
build |
|
build |
2 similar comments
|
build |
|
build |
21 tasks
revans2
reviewed
Jun 7, 2021
|
build |
revans2
previously approved these changes
Jun 9, 2021
sperlingxx
requested review from
GaryShen2008,
jlowe,
NvTimLiu and
tgravescs
as code owners
Signed-off-by: sperlingxx <lovedreamf@gmail.com>
Signed-off-by: sperlingxx <lovedreamf@gmail.com>
sperlingxx
force-pushed
the
collect_set_window
branch
from
cacd764 to
bb09f6b
Compare
Signed-off-by: sperlingxx <lovedreamf@gmail.com>
|
build |
revans2
approved these changes
Jun 10, 2021
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to support
GpuCollectSetas a rolling window aggregation function. It is marked as WIP because it relied on a cuDF fix.Signed-off-by: sperlingxx lovedreamf@gmail.com