support parquet write arrays #2582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build |
Signed-off-by: Bobby Wang <wbo4958@gmail.com>
wbo4958
force-pushed
the
parquet-write-arrays
branch
from
84f64db to
f5088ce
Compare
|
build |
|
@razajafri could you help to review this PR? |
revans2
approved these changes
Jun 8, 2021
razajafri
reviewed
Jun 8, 2021
| @@ -2828,7 +2829,8 @@ object GpuOverrides { | |||
| "Writing data", | |||
| ExecChecks((TypeSig.commonCudfTypes + | |||
| TypeSig.DECIMAL.withPsNote(TypeEnum.DECIMAL, "Only supported for Parquet") + | |||
| TypeSig.STRUCT.withPsNote(TypeEnum.STRUCT, "Only supported for Parquet")).nested(), | |||
| TypeSig.STRUCT.withPsNote(TypeEnum.STRUCT, "Only supported for Parquet") + | |||
There was a problem hiding this comment.
nit: would be good to have an API that takes an array of TypeEnum so we have to duplicate the message Only supported for Parquet
There was a problem hiding this comment.
We can create a s follow-on issue for this as an improvement if you want
There was a problem hiding this comment.
ok, Thx @razajafri, Will create a follow-on issue for this
razajafri
approved these changes
Jun 8, 2021
tgravescs
pushed a commit
that referenced
this pull request
Jun 9, 2021
Signed-off-by: Bobby Wang <wbo4958@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables parquet write for arrays. Please refer to #2307