Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename rapids-4-spark-tools directory to tools #2598

Merged
merged 3 commits into from
Jun 6, 2021

Conversation

nartal1
Copy link
Collaborator

@nartal1 nartal1 commented Jun 4, 2021

This is follow on to rename directory to align with others in the repo based on the discussion #2469 (review).

I will upmerge this PR once all the pending PR's related to qualification and profiling tools are merged. Created this PR for tracking.

@nartal1 nartal1 added the feature request New feature or request label Jun 4, 2021
@nartal1 nartal1 added this to the June 7 - June 18 milestone Jun 4, 2021
@nartal1 nartal1 self-assigned this Jun 4, 2021
@tgravescs
Copy link
Collaborator

looks fine, @nartal1 please upmerge

Signed-off-by: Niranjan Artal <nartal@nvidia.com>
@nartal1 nartal1 force-pushed the profile_rename_directory branch from 98aaf0b to 3c2d09a Compare June 4, 2021 23:36
@nartal1
Copy link
Collaborator Author

nartal1 commented Jun 4, 2021

looks fine, @nartal1 please upmerge

There were some conflicts as some of the files were moved and since it just a directory rename, did a force push. Hope it's okay.

@sameerz sameerz added task Work required that improves the product but is not user facing and removed feature request New feature or request labels Jun 5, 2021
@tgravescs
Copy link
Collaborator

@nartal1 please upmerge

nartal1 added 2 commits June 6, 2021 07:35
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
@nartal1
Copy link
Collaborator Author

nartal1 commented Jun 6, 2021

build

@tgravescs tgravescs merged commit 3e303c0 into NVIDIA:branch-21.06 Jun 6, 2021
NvTimLiu added a commit to NvTimLiu/spark-rapids that referenced this pull request Jun 7, 2021
This is the follow on rename of 'rapids-4-spark-tools' directory to 'tools', to align with NVIDIA#2598

Signed-off-by: Tim Liu <timl@nvidia.com>
tgravescs pushed a commit that referenced this pull request Jun 7, 2021
This is the follow on rename of 'rapids-4-spark-tools' directory to 'tools', to align with #2598

Signed-off-by: Tim Liu <timl@nvidia.com>
nartal1 added a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
* Rename rapids-4-spark-tools directory to tools

Signed-off-by: Niranjan Artal <nartal@nvidia.com>

* update readme and pom

Signed-off-by: Niranjan Artal <nartal@nvidia.com>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
This is the follow on rename of 'rapids-4-spark-tools' directory to 'tools', to align with NVIDIA#2598

Signed-off-by: Tim Liu <timl@nvidia.com>
nartal1 added a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
* Rename rapids-4-spark-tools directory to tools

Signed-off-by: Niranjan Artal <nartal@nvidia.com>

* update readme and pom

Signed-off-by: Niranjan Artal <nartal@nvidia.com>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
This is the follow on rename of 'rapids-4-spark-tools' directory to 'tools', to align with NVIDIA#2598

Signed-off-by: Tim Liu <timl@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Work required that improves the product but is not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants