-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename rapids-4-spark-tools directory to tools #2598
Merged
tgravescs
merged 3 commits into
NVIDIA:branch-21.06
from
nartal1:profile_rename_directory
Jun 6, 2021
Merged
Rename rapids-4-spark-tools directory to tools #2598
tgravescs
merged 3 commits into
NVIDIA:branch-21.06
from
nartal1:profile_rename_directory
Jun 6, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nartal1
requested review from
GaryShen2008,
jlowe,
NvTimLiu,
revans2 and
tgravescs
as code owners
June 4, 2021 22:50
looks fine, @nartal1 please upmerge |
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
nartal1
force-pushed
the
profile_rename_directory
branch
from
June 4, 2021 23:36
98aaf0b
to
3c2d09a
Compare
There were some conflicts as some of the files were moved and since it just a directory rename, did a force push. Hope it's okay. |
sameerz
added
task
Work required that improves the product but is not user facing
and removed
feature request
New feature or request
labels
Jun 5, 2021
@nartal1 please upmerge |
…ofile_rename_directory
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
build |
tgravescs
approved these changes
Jun 6, 2021
NvTimLiu
added a commit
to NvTimLiu/spark-rapids
that referenced
this pull request
Jun 7, 2021
This is the follow on rename of 'rapids-4-spark-tools' directory to 'tools', to align with NVIDIA#2598 Signed-off-by: Tim Liu <timl@nvidia.com>
tgravescs
pushed a commit
that referenced
this pull request
Jun 7, 2021
This is the follow on rename of 'rapids-4-spark-tools' directory to 'tools', to align with #2598 Signed-off-by: Tim Liu <timl@nvidia.com>
nartal1
added a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Rename rapids-4-spark-tools directory to tools Signed-off-by: Niranjan Artal <nartal@nvidia.com> * update readme and pom Signed-off-by: Niranjan Artal <nartal@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
This is the follow on rename of 'rapids-4-spark-tools' directory to 'tools', to align with NVIDIA#2598 Signed-off-by: Tim Liu <timl@nvidia.com>
nartal1
added a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Rename rapids-4-spark-tools directory to tools Signed-off-by: Niranjan Artal <nartal@nvidia.com> * update readme and pom Signed-off-by: Niranjan Artal <nartal@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
This is the follow on rename of 'rapids-4-spark-tools' directory to 'tools', to align with NVIDIA#2598 Signed-off-by: Tim Liu <timl@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is follow on to rename directory to align with others in the repo based on the discussion #2469 (review).
I will upmerge this PR once all the pending PR's related to qualification and profiling tools are merged. Created this PR for tracking.