Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct an issue for README for tools and also correct s3 solution in Args.scala #2618

Merged
merged 4 commits into from
Jun 7, 2021
Merged

Correct an issue for README for tools and also correct s3 solution in Args.scala #2618

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c04cdb4
Signed-off-by: Hao Zhu <hazhu@nvidia.com>
viadea Jun 7, 2021
19629e9
Add doc link for Hadoop-AWS module
viadea Jun 7, 2021
a9d9fe8
Remove S3 instructions.
viadea Jun 7, 2021
bd89a58
Remove S3 instructions from QualificationArgs
viadea Jun 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ mvn -pl .,tools clean verify -DskipTests
```
The jar is generated in below directory :

`./rapids-4-spark-tools/target/rapids-4-spark-tools_2.12-<version>.jar`
`./tools/target/rapids-4-spark-tools_2.12-<version>.jar`

## How to use this tool

Expand Down
4 changes: 2 additions & 2 deletions tools/src/main/scala/com/nvidia/spark/rapids/tool/profiling/ProfileArgs.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ rapids-4-spark-tools_2.12-<version>.jar /path/to/eventlog1 /path/to/eventlog2
rapids-4-spark-tools_2.12-<version>.jar /path/to/DirOfManyEventLogs

# If any event log is from S3:
export AWS_ACCESS_KEY_ID=xxx
export AWS_SECRET_ACCESS_KEY=xxx
# Need to download hadoop-aws-<version>.jar and aws-java-sdk-<version>.jar firstly,
# and then put fs.s3a.access.key and fs.s3a.secret.key in $SPARK_HOME/conf/hdfs-site.xml.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S3a is a separate filesystem from HDFS. It's typically stored in core-site.xml. But you can also just configure in spark via spark.hadoop.fs.s3a... settings. Environment variables should work too if EnvironmentVariableCredentialsProvider is configured.

I suggest that we don't go into details in our repo, and simply defer/link Hadoop/Spark docs for this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gerashegalov I just added a doc link in README and removed the instructions in 2 Args.scala files.
How is now?thx

./bin/spark-submit --class com.nvidia.spark.rapids.tool.profiling.ProfileMain
rapids-4-spark-tools_2.12-<version>.jar s3a://<BUCKET>/eventlog1 /path/to/eventlog2

Expand Down
4 changes: 2 additions & 2 deletions tools/src/main/scala/com/nvidia/spark/rapids/tool/qualification/QualificationArgs.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ rapids-4-spark-tools_2.12-<version>.jar /path/to/eventlog1 /path/to/eventlog2
rapids-4-spark-tools_2.12-<version>.jar /path/to/DirOfManyEventLogs

# If any event log is from S3:
export AWS_ACCESS_KEY_ID=xxx
export AWS_SECRET_ACCESS_KEY=xxx
# Need to download hadoop-aws-<version>.jar and aws-java-sdk-<version>.jar firstly,
# and then put fs.s3a.access.key and fs.s3a.secret.key in $SPARK_HOME/conf/hdfs-site.xml.
./bin/spark-submit --class com.nvidia.spark.rapids.tool.qualification.QualificationMain
rapids-4-spark-tools_2.12-<version>.jar s3a://<BUCKET>/eventlog1 /path/to/eventlog2

Expand Down