Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add physical plan to the dot file as the graph label #2640

Merged
merged 3 commits into from
Jun 9, 2021
Merged

Add physical plan to the dot file as the graph label #2640

merged 3 commits into from
Jun 9, 2021

Conversation

gerashegalov
Copy link
Collaborator

@gerashegalov gerashegalov commented Jun 8, 2021 •
edited
Loading

Inspired by #2636

Signed-off-by: Gera Shegalov gera@apache.org

@gerashegalov
Add physical plan to the dot file as graph label
9e3d599 
Signed-off-by: Gera Shegalov <gera@apache.org>
@gerashegalov
Copy link
Collaborator Author

build

@nartal1
Copy link
Collaborator

nartal1 commented Jun 8, 2021 •
edited
Loading

Could you please target this to branch-21.06

@gerashegalov
Copy link
Collaborator Author

Screenshot from 2021-06-08 15-05-20

@gerashegalov gerashegalov changed the base branch from branch-21.08 to branch-21.06 June 8, 2021 22:07
@tgravescs
Copy link
Collaborator

build

@gerashegalov gerashegalov self-assigned this Jun 8, 2021
@gerashegalov gerashegalov added this to the June 7 - June 18 milestone Jun 8, 2021
@gerashegalov
Copy link
Collaborator Author

looking into test failure

@gerashegalov
Copy link
Collaborator Author

build

@gerashegalov gerashegalov requested a review from tgravescs June 9, 2021 00:47
nartal1
nartal1 approved these changes Jun 9, 2021
View reviewed changes
Copy link
Collaborator

@nartal1 nartal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgravescs tgravescs merged commit bb6d2ab into NVIDIA:branch-21.06 Jun 9, 2021
@gerashegalov gerashegalov deleted the physicalPlanLabelForDotFiles branch June 9, 2021 16:36
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
@gerashegalov
Add physical plan to the dot file as the graph label (NVIDIA#2640)
157293e 
* Add physical plan to the dot file as graph label

Signed-off-by: Gera Shegalov <gera@apache.org>

* review

* test fix
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
@gerashegalov
Add physical plan to the dot file as the graph label (NVIDIA#2640)
c3123c8 
* Add physical plan to the dot file as graph label

Signed-off-by: Gera Shegalov <gera@apache.org>

* review

* test fix
@sameerz sameerz added the task Work required that improves the product but is not user facing label Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nartal1 nartal1 nartal1 approved these changes

@tgravescs tgravescs Awaiting requested review from tgravescs

Assignees

@gerashegalov gerashegalov

Labels
task Work required that improves the product but is not user facing
Projects
None yet
Milestone
June 7 - June 18
Development

Successfully merging this pull request may close these issues.
4 participants
@gerashegalov @nartal1 @tgravescs @sameerz