Print CPU and GPU output when _assert_equal fails to help debug given… #2657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abellina
requested review from
GaryShen2008,
jlowe,
NvTimLiu and
tgravescs
as code owners
gerashegalov
reviewed
Jun 9, 2021
| _assert_equal(cpu, gpu, float_check=get_float_check(), path=[]) | ||
| except Exception as ex: | ||
| print("CPU OUTPUT: %s \n\n GPU OUTPUT: %s" % (cpu, gpu)) | ||
| raise ex |
There was a problem hiding this comment.
nit: we can re-raise the last exception with less boilerplate
try:
...
except:
...
raise| try: | ||
| _assert_equal(cpu, gpu, float_check=get_float_check(), path=[]) | ||
| except Exception as ex: | ||
| print("CPU OUTPUT: %s \n\n GPU OUTPUT: %s" % (cpu, gpu)) |
There was a problem hiding this comment.
nit: multi-line f string
There was a problem hiding this comment.
Not entirely sure if I understood this comment. But I split this into two print statements, please let me know if I misunderstood.
… the failed path Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
abellina
force-pushed
the
debug/print_sort_in_part_output
branch
from
9725ff1 to
259a6a1
Compare
gerashegalov
approved these changes
Jun 10, 2021
|
build |
1 similar comment
|
build |
revans2
approved these changes
Jun 10, 2021
revans2
reviewed
Jun 10, 2021
| _assert_equal(cpu, gpu, float_check=get_float_check(), path=[]) | ||
| except: | ||
| print("CPU OUTPUT: %s" % cpu) | ||
| print("GPU OUTPUT: %s" % gpu) |
There was a problem hiding this comment.
nit: technically this is not guaranteed to be the output for the GPU or the CPU because we could have sorted it locally first, but I think everyone will understand and I think this is the right place to print out the info.
|
@abellina is this supposed to be 21.06? Should this be updated to 21.08? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… the failed path
Signed-off-by: Alessandro Bellina abellina@nvidia.com
This seems like a simple way to capture the output of a test on failure, to help debug. One could take this output and them diff the cpu and the gpu, so one can match that with the "path", as already provided by the test framework on failure.
Re: #2477.