Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tools inherit common dependency versions from parent pom #2661

Merged
merged 2 commits into from
Jun 10, 2021
Merged

Make tools inherit common dependency versions from parent pom #2661

merged 2 commits into from
Jun 10, 2021

Conversation

gerashegalov
Copy link
Collaborator

Tools should not unnecessarily override parent pom versions

Recurrence of #2088

Signed-off-by: Gera Shegalov gera@apache.org

@gerashegalov gerashegalov changed the base branch from branch-21.08 to branch-21.06 June 9, 2021 20:05
@gerashegalov
Copy link
Collaborator Author

build

@gerashegalov gerashegalov self-assigned this Jun 9, 2021
@gerashegalov
rebase
866bdc9 
Signed-off-by: Gera Shegalov <gera@apache.org>
@gerashegalov gerashegalov force-pushed the toolsInerentVersionsFromPom branch from 67c9049 to 866bdc9 Compare June 9, 2021 21:20
@gerashegalov
Copy link
Collaborator Author

build

@sameerz
Copy link
Collaborator

sameerz commented Jun 10, 2021

Does this belong in 21.06 or 21.08?

@gerashegalov gerashegalov added the build Related to CI / CD or cleanly building label Jun 10, 2021
@gerashegalov gerashegalov changed the base branch from branch-21.06 to branch-21.08 June 10, 2021 00:13
@gerashegalov
Copy link
Collaborator Author

re-targetted to branch-21.08

@pxLi
Copy link
Collaborator

pxLi commented Jun 10, 2021

build

@gerashegalov
Copy link
Collaborator Author

build

1 similar comment
@pxLi
Copy link
Collaborator

pxLi commented Jun 10, 2021

build

@gerashegalov gerashegalov merged commit 67abfde into NVIDIA:branch-21.08 Jun 10, 2021
@gerashegalov gerashegalov deleted the toolsInerentVersionsFromPom branch June 10, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgravescs tgravescs tgravescs approved these changes

@GaryShen2008 GaryShen2008 Awaiting requested review from GaryShen2008 GaryShen2008 is a code owner

@jlowe jlowe Awaiting requested review from jlowe jlowe is a code owner

@NvTimLiu NvTimLiu Awaiting requested review from NvTimLiu NvTimLiu is a code owner

@revans2 revans2 Awaiting requested review from revans2 revans2 is a code owner

Assignees

@gerashegalov gerashegalov

Labels
build Related to CI / CD or cleanly building
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gerashegalov @sameerz @pxLi @tgravescs