Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid NPE when casting empty strings to ints #2681

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Avoid NPE when casting empty strings to ints #2681

merged 1 commit into from
Jun 10, 2021

Conversation

revans2
Copy link
Collaborator

@revans2 revans2 commented Jun 10, 2021

This fixes #2680

@revans2
Avoid NPE when casting empty strings to ints
0dd6e1d 
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
@revans2 revans2 added bug Something isn't working P0 Must have for release labels Jun 10, 2021
@revans2 revans2 added this to the June 7 - June 18 milestone Jun 10, 2021
@revans2 revans2 self-assigned this Jun 10, 2021
@revans2 revans2 linked an issue Jun 10, 2021 that may be closed by this pull request
[BUG] cast can throw NPE #2680
Closed
@revans2
Copy link
Collaborator Author

revans2 commented Jun 10, 2021

build

tgravescs
tgravescs reviewed Jun 10, 2021
View reviewed changes
integration_tests/src/main/python/cast_test.py

import pytest

from asserts import assert_gpu_and_cpu_are_equal_collect, assert_gpu_and_cpu_are_equal_sql, assert_gpu_and_cpu_error
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, I think there are some extra imports here but they can be removed later

mythrocks
mythrocks approved these changes Jun 10, 2021
View reviewed changes
Copy link
Collaborator

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@revans2 revans2 merged commit 2f977dc into NVIDIA:branch-21.06 Jun 10, 2021
@revans2 revans2 deleted the cast_npe branch June 10, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mythrocks mythrocks mythrocks approved these changes

@tgravescs tgravescs tgravescs approved these changes

@abellina abellina abellina approved these changes

Assignees

@revans2 revans2

Labels
bug Something isn't working P0 Must have for release
Projects
None yet
Milestone
June 7 - June 18
Development

Successfully merging this pull request may close these issues.

[BUG] cast can throw NPE
4 participants
@revans2 @abellina @tgravescs @mythrocks