Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add file size check to pre-merge CI #2716

Merged
merged 2 commits into from
Jun 15, 2021
Merged

Add file size check to pre-merge CI #2716

merged 2 commits into from
Jun 15, 2021

Conversation

pxLi
Copy link
Collaborator

@pxLi pxLi commented Jun 15, 2021 •
edited
Loading

fix #2674 using #2699

We could add --all-files after the existing large testing files get moved our or compressed.

[2021-06-15T02:56:04.451Z] + BASE_REF=e0ad5882ee04d90acc8e9754a0ea2d07b924f58d
[2021-06-15T02:56:04.451Z] + pre-commit run check-added-large-files --from-ref e0ad5882ee04d90acc8e9754a0ea2d07b924f58d --to-ref HEAD
[2021-06-15T02:56:08.648Z] [INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.git.
[2021-06-15T02:56:08.907Z] [INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.git.
[2021-06-15T02:56:08.907Z] [INFO] Once installed this environment will be reused.
[2021-06-15T02:56:08.907Z] [INFO] This may take a few minutes...
[2021-06-15T02:56:13.091Z] Check for file over 1.5MiB...............................................Passed

@pxLi pxLi added the build Related to CI / CD or cleanly building label Jun 15, 2021
@pxLi pxLi requested review from revans2 and tgravescs as code owners June 15, 2021 02:46
@pxLi
modify comments
2996168 
Signed-off-by: Peixin Li <pxli@nyu.edu>
@pxLi pxLi force-pushed the add-file-size-check-to-pre-merge branch from 59a317e to 2996168 Compare June 15, 2021 02:47
@pxLi
Copy link
Collaborator Author

pxLi commented Jun 15, 2021

build

@pxLi pxLi merged commit 4133882 into NVIDIA:branch-21.08 Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NvTimLiu NvTimLiu NvTimLiu approved these changes

@GaryShen2008 GaryShen2008 Awaiting requested review from GaryShen2008 GaryShen2008 is a code owner

@jlowe jlowe Awaiting requested review from jlowe jlowe is a code owner

@revans2 revans2 Awaiting requested review from revans2 revans2 is a code owner

@tgravescs tgravescs Awaiting requested review from tgravescs tgravescs is a code owner

Assignees
No one assigned
Labels
build Related to CI / CD or cleanly building
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] add file size check for pre-merge CI run
2 participants
@pxLi @NvTimLiu