-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support string repeat
SQL
#2728
Conversation
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuOverrides.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/stringFunctions.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/stringFunctions.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/stringFunctions.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/stringFunctions.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/stringFunctions.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/stringFunctions.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/stringFunctions.scala
Outdated
Show resolved
Hide resolved
@ttnghia the commit needs to be signed off, see the signoff section in the contributing guide for details. |
@ttnghia please retarget to branch 21.10 when you get a chance. |
Signed-off-by: Nghia Truong <nghiatruong.vn@gmail.com>
Signed-off-by: Nghia Truong <nghiatruong.vn@gmail.com>
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/stringFunctions.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Nghia Truong <nghiatruong.vn@gmail.com>
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuOverrides.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Nghia Truong <nghiatruong.vn@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me other than a small assert result nit.
tests/src/test/scala/com/nvidia/spark/rapids/unit/StringRepeatUnitTest.scala
Outdated
Show resolved
Hide resolved
tests/src/test/scala/com/nvidia/spark/rapids/unit/StringRepeatUnitTest.scala
Outdated
Show resolved
Hide resolved
…UnitTest.scala Co-authored-by: Jason Lowe <jlowe@nvidia.com>
…UnitTest.scala Co-authored-by: Jason Lowe <jlowe@nvidia.com>
build |
The latest test run failed because of a breaking change in the cudf APIs that was merged in and the corresponding plugin change has not gone in yet. |
build |
1 similar comment
build |
hi. please check the build log before trigger again thx!
this PR did not include RapidsConf and SupportedOpsDocs update well, so it failed the check |
Signed-off-by: Nghia Truong <nghiatruong.vn@gmail.com>
Oh thanks for letting me know. I have updated the docs. |
Actually I think we should not, otherwise people could push new commits which could do whatever they want to our repo after the initial approval, this could be horrible :P |
People should know what they are doing, not "whatever they want" like that 😃. I observed (from cudf) that after approvals the authors usually push more minor changes related to docs/typos etc. If every new change requires approvals again then it is very inconvenient for both the authors and the reviewers. Of course, if there are new changes in the code then the authors can request re-review anytime. |
haha yeah, I mean cudf approval is horrible. For our repo, if PR tests pass pre-merge CI but requires to add some minor changes like comments/docs only (not for generated docs like configs.md or supported_ops.md), people could just add |
It may be inconvenient, but a review on a change, even a small one, is worth the trouble to minimize potential problems. Doing a review on every change is a good habit. We can still move quickly while doing the reviews. |
build |
This PR implements
repeat
SQL, and closes #68.Example: