Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add link to Mellanox RoCE documentation and mention --without-ucx installation option #2745

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Add link to Mellanox RoCE documentation and mention --without-ucx installation option #2745

merged 1 commit into from
Jun 21, 2021

Conversation

abellina
Copy link
Collaborator

…out-ucx for the MOFED installation script

Signed-off-by: Alessandro Bellina abellina@nvidia.com

This is relatively small, but if it fits in 21.06 we can put it there. Else we can target to 21.08.

@sameerz @jlowe

@abellina
Add a link for Mellanox documentation on RoCE and a pointer to --with…
f4c210c 
…out-ucx for the MOFED installation script

Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
@abellina abellina changed the base branch from branch-21.08 to branch-21.06 June 18, 2021 18:30
@abellina abellina added documentation Improvements or additions to documentation shuffle things that impact the shuffle plugin labels Jun 18, 2021
@jlowe jlowe changed the title Add a link for Mellanox documentation on RoCE and a pointer to --with… Add link to Mellanox RoCE documentation and mention --without-ucx installation option Jun 18, 2021
jlowe
jlowe approved these changes Jun 18, 2021
View reviewed changes
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK to me, will defer to @sameerz on whether this is appropriate for 21.06 at this point.

@jlowe
Copy link
Member

jlowe commented Jun 18, 2021

build

@abellina
Copy link
Collaborator Author

@sameerz ok to merge to 21.06?

@sameerz sameerz added this to the June 21 - July 2 milestone Jun 21, 2021
@sameerz sameerz merged commit 269e7a7 into NVIDIA:branch-21.06 Jun 21, 2021
@abellina abellina deleted the shuffle/tweak_shuffle_docs_21.06 branch June 21, 2021 19:14
@abellina
Copy link
Collaborator Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation shuffle things that impact the shuffle plugin
Projects
None yet
Milestone
June 21 - July 2
Development

Successfully merging this pull request may close these issues.
3 participants
@abellina @jlowe @sameerz