-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profiling tool: Update comparison mode output format and add error handling #2762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
tgravescs
reviewed
Jun 21, 2021
tools/src/main/scala/com/nvidia/spark/rapids/tool/profiling/Analysis.scala
Outdated
Show resolved
Hide resolved
tools/src/main/scala/org/apache/spark/sql/rapids/tool/profiling/ApplicationInfo.scala
Outdated
Show resolved
Hide resolved
tools/src/main/scala/com/nvidia/spark/rapids/tool/profiling/CompareApplications.scala
Show resolved
Hide resolved
tools/src/main/scala/org/apache/spark/sql/rapids/tool/profiling/ApplicationInfo.scala
Outdated
Show resolved
Hide resolved
tools/src/main/scala/com/nvidia/spark/rapids/tool/profiling/ProfileMain.scala
Show resolved
Hide resolved
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
build |
tgravescs
reviewed
Jun 23, 2021
tools/README.md
Outdated
|1 |0 |4 |13984648396|13984648396 |0 |null |null |null |null |null |null | | ||
|1 |1 |4 |13984648396|13984648396 |0 |null |null |null |null |null |null | | ||
+--------+-----------------+------------+----------------+-----------+------------+-------------+-------------+--------------+------------------+---------------+-------+-------+ | ||
|appIndex|resourceProfileId|numExecutors|coresPerExecutor|maxMem |maxOnHeapMem|maxOffHeapMem|executorCores|executorMemory|numGpusPerExecutor|executorOffHeap|taskCpu|taskGpu| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is difference in executor cores and cores per executor?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are same. Removed duplicate field. PTAL.
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
build |
tgravescs
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes multiple FEA/bugs.
Updated the tests and README to relfect these changes.
After adding appName, output will be as below:
For comparison mode, output is updated for below functions:
a. Executor Information:
b. Rapids properties which are explicitly set
c. SQL Duration and Executor CPU Time Percent - (sorted order based on appIndex)
d. Failed tasks, jobs, stages include appIndex for better mapping: