Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make spark303 shim version w/o snapshot and add shim layer for spark304 #2784

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Make spark303 shim version w/o snapshot and add shim layer for spark304 #2784

merged 1 commit into from
Jun 24, 2021

Conversation

pxLi
Copy link
Collaborator

@pxLi pxLi commented Jun 23, 2021 •
edited
Loading

Signed-off-by: Peixin Li pxli@nyu.edu

fix #2782

  1. remove snapshot version from spark 3.0.3 shim
  2. add shim layer of spark 3.0.4-SNAPSHOT
  3. reduce shim layers tests in pre-merge change, related to Premerge build takes too long (3 hours) #2731

Please help review, I will trigger pre-merge check after spark 3.0.3 get officially released

@pxLi
Make spark303 not snapshot and add shim layer for spark304
f7b2228 
Signed-off-by: Peixin Li <pxli@nyu.edu>
@pxLi pxLi added documentation Improvements or additions to documentation build Related to CI / CD or cleanly building labels Jun 23, 2021
@pxLi pxLi requested a review from GaryShen2008 as a code owner June 23, 2021 02:58
@tgravescs tgravescs marked this pull request as draft June 23, 2021 14:17
@tgravescs
Copy link
Collaborator

converted to draft just to prevent merging until 3.0.3 all released.

tgravescs
tgravescs approved these changes Jun 23, 2021
View reviewed changes
Copy link
Collaborator

@tgravescs tgravescs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, pending the artifacts released, thanks @pxLi

@pxLi
Copy link
Collaborator Author

pxLi commented Jun 24, 2021

build

@pxLi pxLi marked this pull request as ready for review June 24, 2021 03:58
@pxLi pxLi merged commit 0cc7521 into NVIDIA:branch-21.08 Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgravescs tgravescs tgravescs approved these changes

@jlowe jlowe jlowe approved these changes

@GaryShen2008 GaryShen2008 Awaiting requested review from GaryShen2008 GaryShen2008 is a code owner

@NvTimLiu NvTimLiu Awaiting requested review from NvTimLiu NvTimLiu is a code owner

@revans2 revans2 Awaiting requested review from revans2 revans2 is a code owner

Assignees
No one assigned
Labels
build Related to CI / CD or cleanly building documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Spark 3.0.3 release support
3 participants
@pxLi @tgravescs @jlowe