Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pre-merge to use reserved_pool [skip ci] #2801

Merged
merged 2 commits into from
Jun 24, 2021

Conversation

pxLi
Copy link
Collaborator

@pxLi pxLi commented Jun 24, 2021

Signed-off-by: Peixin Li pxli@nyu.edu

use the jenkins lockable resources plugin to achieve a reserved resource pool.
so pre-merge can try use any available GPUs in pool.

All nightly pipelines have already applied the change to lock the GPU resource they are using

Tested in forked repo.

Signed-off-by: Peixin Li <pxli@nyu.edu>
@pxLi pxLi added the build Related to CI / CD or cleanly building label Jun 24, 2021
@pxLi pxLi requested a review from GaryShen2008 as a code owner June 24, 2021 04:42
zhanga5
zhanga5 previously approved these changes Jun 24, 2021
Copy link
Contributor

@zhanga5 zhanga5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pxLi
Copy link
Collaborator Author

pxLi commented Jun 24, 2021

build

GaryShen2008
GaryShen2008 previously approved these changes Jun 24, 2021
@pxLi pxLi dismissed stale reviews from GaryShen2008 and zhanga5 via 1ee055d June 24, 2021 07:33
@pxLi pxLi force-pushed the use-resource-pool-for-pre-merge branch from 1ee055d to 428c47e Compare June 24, 2021 07:34
@pxLi
Copy link
Collaborator Author

pxLi commented Jun 24, 2021

build

@pxLi pxLi force-pushed the use-resource-pool-for-pre-merge branch from 428c47e to 0b2fb34 Compare June 24, 2021 07:46
@pxLi
Copy link
Collaborator Author

pxLi commented Jun 24, 2021

build

@pxLi pxLi merged commit 3121f4c into NVIDIA:branch-21.08 Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to CI / CD or cleanly building
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants