Use SecureRandom for UCPListener TCP port choice #2810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
sameerz
added
the
task
|
Side note: I did check in this scenario that With the default algorithm |
jlowe
previously approved these changes
Jun 24, 2021
| @@ -183,6 +183,7 @@ class UCX(transport: UCXShuffleTransport, executor: BlockManagerId, rapidsConf: | |||
| worker = context.newWorker(workerParams) | |||
| logInfo(s"UCX Worker created") | |||
| if (rapidsConf.shuffleUcxUseSockaddr) { | |||
| val secureRandom = new SecureRandom() | |||
There was a problem hiding this comment.
Nit: Why not move this within the one block that needs it? If the port is specified in the conf then this will still construct an unused instance.
|
build |
gerashegalov
approved these changes
Jun 24, 2021
jlowe
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alessandro Bellina abellina@nvidia.com
Please note that once UCX 1.11 is released, we will remove the need for this choice since UCX will delegate to the kernel to set the ephemeral port.