Truncate long plan labels and refer to "print-plans" #2821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properly treat graphviz compiled with the default 16K label max Closes NVIDIA#2710. Signed-off-by: Gera Shegalov <gera@apache.org>
tgravescs
reviewed
Jun 25, 2021
| physicalPlan: String, | ||
| maxLength: Int = 16384 | ||
| ): String = { | ||
| val sqlPlanFile = s"file://$outputDir/planDescriptions-$appId" |
There was a problem hiding this comment.
outputDir isn't necessarily file://, could be in hdfs for instance, I guess maybe you are thinking they download it anyway so when open it should be? But if they do that outputdir could be different
There was a problem hiding this comment.
yes forgot about non-OS-mounted locations.
| s"""<<table border="0"> | ||
| |<tr><td>Application: $appId, Query: $sqlId</td></tr> | ||
| |<tr><td>$sqlPlanPlaceHolder</td></tr> | ||
| |<tr><td href="$sqlPlanFile"> |
There was a problem hiding this comment.
I would just say see the output from --print-plans and not do the link.
gerashegalov
changed the title
|
build |
tgravescs
approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly treat graphviz compiled with the default 16K label max
Closes #2710.
Signed-off-by: Gera Shegalov gera@apache.org