Add a threadpool to Qualification tool to process logs in parallel #2841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
|
build |
revans2
approved these changes
Jun 29, 2021
| .setDaemon(true).setNameFormat("qualTool" + "-%d").build() | ||
| logInfo(s"Threadpool size is $nThreads") | ||
| private val threadPool = Executors.newFixedThreadPool(nThreads, threadFactory) | ||
| .asInstanceOf[ThreadPoolExecutor] |
There was a problem hiding this comment.
nit: redundant cast?
Comment on lines
+61
to
+66
| threadPool.shutdown() | ||
| if (!threadPool.awaitTermination(waitTimeInSec, TimeUnit.SECONDS)) { | ||
| logError(s"Processing log files took longer then $waitTimeInSec seconds," + | ||
| " stopping processing any more event logs") | ||
| threadPool.shutdownNow() | ||
| } |
There was a problem hiding this comment.
we may get an InterruptedException in awaitTermination, may want to surround it with try/finally and place shutdownNow into finally.
| None | ||
| case e: Exception => | ||
| // catch all exceptions and skip that file | ||
| logWarning(s"Got unexpected exception processing file: $path", e) | ||
| logWarning(s"Got unexpected exception processing file: ${path.eventLog.toString}", e) |
There was a problem hiding this comment.
nit: toString is redundant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a threadpool and parameters to configure timeout and number of threads (defaults to cores on host/4).
Updated some log messages so it shows path or something useful since now the log messages don't come out in sequential order.
Fixed a bug with printing out the text file when there aren't any apps in QualOutputWriter.
Times to process 105 log files went from about 6.5 minutes to 45 seconds, interestingly enough, processing 210 log files only takes a bit longer at like 50 seconds, it looks like a few of the log files are skewed and take much longer than others.