GPU Active Messages for all buffer types #2926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…IDIA#2735)" (NVIDIA#2805)" This reverts commit 13febbd.
abellina
requested review from
GaryShen2008,
jlowe,
NvTimLiu,
revans2 and
tgravescs
as code owners
Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
abellina
force-pushed
the
shuffle/gpu_active_messages_bring_back
branch
from
d4625e4 to
d874dcd
Compare
jlowe
approved these changes
Jul 13, 2021
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This undoes this revert.
The change is pretty much the same, but I had to fix diffs as there were conflicts with the UCPListener change.
I upgrade UCX to 1.11.0-rc3 in this change also, and handle:
I also tested #2892, and I can see that the issue is not reproducible with plain active messages (we no longer use tags).
Updating the docs for UCX 1.11.0 is tracked here: #2925. I am hoping we can fix the docs once 1.11.0 is not a release candidate.
Closes #2807.