Qualification tool support recognizing decimal operations #2928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Graves <tgraves@apache.org>
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
|
build |
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
|
build |
nartal1
previously approved these changes
Jul 15, 2021
|
LGTM. Please resolve conflicts. |
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the qualification tool trying to recognize decimal operations and adds them to the potential problems columns. It also adds any sql ops with decimals to the sql duration for problematic.
This fixes a couple of issues found during testing, like if the sql start event is missing but end event was there, we were setting time to 0 rather than the sql end time.
Output now looks like:
csv:
specifically note the Potential Problems and SQL Duration with Potential Problems