qualification tool: add filtering by app start time #2940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Graves <tgraves@apache.org>
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
|
build |
nartal1
reviewed
Jul 15, 2021
| } | ||
| } | ||
| filtered.map(_.eventlog).toSeq | ||
| } else if (appArgs.startAppTime.isSupplied) { |
There was a problem hiding this comment.
Should we support both the cases? i.e If applciationName is given along with time range in the commandline.
--application-name "appName" --start-app-time "1w"
If AND is not supported, then we can document that. I will follow the same in my follow on PR's for limit.
There was a problem hiding this comment.
yeah that is a good point we talked about this, it is officially a P1 so perhaps lets do taht as a follow on once we have all the filtering features in and make sure we have tests that will cover all the cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved story:
As a user, I want to select log files for applications whose application start event occurred within a specific time range so that I can select only jobs I've run, e.g., in the last week, month, or quarter
Note I also fixed a few bugs in here with the while loop going over lines. one with counting events and a second when exception thrown dealing with incrementing i.