Fix childExprs list for GpuWindowExpression, for Spark 3.1.x. #2944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes NVIDIA#2939. When the type-checking for expressions in `RapidsMeta` was changed in NVIDIA#2888 (i.e. commit 1a09322), `OffsetWindowFunctionMeta` was modified to include `input`, `offset`, and `default` expressions among its `childExprs`. Unfortunately, the commit neglected to replicate that change in `Spark311Shims` `OffsetWindowFunctionMeta`. The error manifests as a failure to do type-checks for `LEAD()`/`LAG()` window functions, with the error: `java.lang.AssertionError: assertion failed: Lead expected at least 3 but found 0`. This commit should remedy the situation, and allow `LEAD()`/`LAG()` to function correctly. Signed-off-by: Mithun RK <mythrocks@gmail.com>
mythrocks
force-pushed
the
rapids-meta-for-lead-lag-3.1.x
branch
from
9aad52e to
dcfe090
Compare
|
build |
sperlingxx
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2939.
When the type-checking for expressions in
RapidsMetawas changed in #2888 (i.e. commit 1a09322),OffsetWindowFunctionMetawas modified to includeinput,offset, anddefaultexpressions amongits
childExprs.Unfortunately, the commit neglected to replicate that change in
Spark311ShimsOffsetWindowFunctionMeta.The error manifests as a failure to do type-checks for
LEAD()/LAG()window functions, with the message:java.lang.AssertionError: assertion failed: Lead expected at least 3 but found 0.This commit should remedy the situation, and allow
LEAD()/LAG()to function correctly.