Remove unnecessary copies of ParquetCachedBatchSerializer #2948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
razajafri
force-pushed
the
remove-serializers
branch
from
b51bc2e to
993c61c
Compare
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
|
build |
jlowe
reviewed
Jul 16, 2021
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
Sorry, I left it out for the draft, but forgot to remove it post our meeting |
|
build |
jlowe
approved these changes
Jul 16, 2021
jlowe
requested changes
Jul 16, 2021
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
jlowe
approved these changes
Jul 16, 2021
|
build |
jlowe
requested changes
Jul 16, 2021
sameerz
added
the
task
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
razajafri
requested review from
GaryShen2008,
NvTimLiu,
revans2 and
tgravescs
as code owners
|
build |
jlowe
reviewed
Jul 19, 2021
Co-authored-by: Jason Lowe <jlowe@nvidia.com>
|
build |
jlowe
approved these changes
Jul 20, 2021
gerashegalov
pushed a commit
to gerashegalov/spark-rapids
that referenced
this pull request
Jul 25, 2021
* removed unnecessary copies of ParquetCachedBatchSerializer Signed-off-by: Raza Jafri <rjafri@nvidia.com> * optimized import Signed-off-by: Raza Jafri <rjafri@nvidia.com> * removed serializer for 320 Signed-off-by: Raza Jafri <rjafri@nvidia.com> * updated docs Signed-off-by: Raza Jafri <rjafri@nvidia.com> * changed package Signed-off-by: Raza Jafri <rjafri@nvidia.com> * Update jenkins/spark-tests.sh Co-authored-by: Jason Lowe <jlowe@nvidia.com> Co-authored-by: Raza Jafri <rjafri@nvidia.com> Co-authored-by: Jason Lowe <jlowe@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided to remove the extra serializers and have a single version of it in the 311 shims. The package name will be changed to better suit whatever strategy we come up as a part of supporting Spark 3.2
Fixes #2905
Signed-off-by: Raza Jafri rjafri@nvidia.com