Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert that CPU and GPU row fields match when present #2973

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Assert that CPU and GPU row fields match when present #2973

merged 1 commit into from
Jul 20, 2021

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Jul 20, 2021

While investigating #2965, I noticed that the assert code was checking if both the CPU and GPU had fields but was not verifying that the two had the same fields. This adds a sanity check that the CPU and GPU fields match before trying to lookup values by the field names.

@jlowe
Assert that CPU and GPU row fields match when present
a6c0475 
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
@jlowe jlowe added the test Only impacts tests label Jul 20, 2021
@jlowe jlowe self-assigned this Jul 20, 2021
@jlowe
Copy link
Member Author

jlowe commented Jul 20, 2021

build

@sameerz sameerz added this to the July 19 - July 30 milestone Jul 20, 2021
@jlowe jlowe merged commit d641125 into NVIDIA:branch-21.08 Jul 20, 2021
@jlowe jlowe mentioned this pull request Jul 21, 2021
Closed
@jlowe jlowe deleted the fix-struct-assert branch September 10, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuhushukla kuhushukla kuhushukla approved these changes

Assignees

@jlowe jlowe

Labels
test Only impacts tests
Projects
None yet
Milestone
July 19 - July 30
Development

Successfully merging this pull request may close these issues.
3 participants
@jlowe @kuhushukla @sameerz