Qualification tool: fix performance regression #2974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
tgravescs
changed the title
|
build |
nartal1
approved these changes
Jul 20, 2021
|
integration test failed which has nothing to do with this change since this is in tools, even at that doesn't show what failed. |
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2972
It turns out this while loop is 4-5x slower. One particular event log took about 4.5 seconds to process before and when we switched to use while it took slower to 20 seconds.
In this case we use find{} instead to loop through all elements until we hit an event that says we are done. The done is really only used for the app filtering logic when we want to stop processing the event log after the app start event.
Signed-off-by: Thomas Graves tgraves@nvidia.com