Support Sort on nested struct #3034
Conversation
Signed-off-by: sperlingxx <lovedreamf@gmail.com>
|
build |
| timestamp_gen, | ||
| decimal_gen_default, | ||
| StructGen([('child1', byte_gen)]), | ||
| # string_gen, |
There was a problem hiding this comment.
If they were no longer needed, better to remove them.
There was a problem hiding this comment.
Agree if we don't think we need these any more then we should delete them instead of commenting them out. But that said are we removing this because of performance? If so then you could refactor it so there is a single test with one column for each type we want to test and do a single join. Was it commented out just because you were testing? It would be nice to know why these tests are being removed so we can make a proper decision on how to deal with it.
There was a problem hiding this comment.
These tests are necessary. I just forgot to uncomment them after the debugging work on Array of Byte. I am sorry for making you confused :(
| timestamp_gen, | ||
| decimal_gen_default, | ||
| StructGen([('child1', byte_gen)]), | ||
| # string_gen, |
There was a problem hiding this comment.
Agree if we don't think we need these any more then we should delete them instead of commenting them out. But that said are we removing this because of performance? If so then you could refactor it so there is a single test with one column for each type we want to test and do a single join. Was it commented out just because you were testing? It would be nice to know why these tests are being removed so we can make a proper decision on how to deal with it.
|
build |
Closes #2878