Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gh-pages for 21.08 release #3035

Closed
wants to merge 8 commits into from
Closed

Update gh-pages for 21.08 release #3035

wants to merge 8 commits into from

Conversation

nvliyuan
Copy link
Collaborator

Signed-off-by: Yuan Li yuali@nvidia.com

Update gh-pages for 21.08 release #3030

nvliyuan added 2 commits July 27, 2021 18:31
Signed-off-by: yuali <yuali@nvidia.com>
Signed-off-by: yuali <yuali@nvidia.com>
@nvliyuan
Copy link
Collaborator Author

Update all documents except "download.md", maybe @viadea and @Karthikeyan can help me to check the "Release Notes" details of 21.08

@sameerz sameerz added the documentation Improvements or additions to documentation label Jul 27, 2021
@sameerz sameerz added this to the July 19 - July 30 milestone Jul 27, 2021
Copy link
Collaborator

@sameerz sameerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs updates from PR #3080.

Signed-off-by: yuali <yuali@nvidia.com>
Signed-off-by: yuali <yuali@nvidia.com>
@nvliyuan
Copy link
Collaborator Author

Needs updates from PR #3080.

done

@nvliyuan nvliyuan marked this pull request as ready for review August 10, 2021 08:23
@nvliyuan nvliyuan requested a review from sameerz August 10, 2021 08:27
@nvliyuan
Copy link
Collaborator Author

@sameerz @viadea @GaryShen2008 I just finish the document update, could you please help review the pull request?

@nvliyuan nvliyuan marked this pull request as draft August 12, 2021 05:57
nvliyuan and others added 2 commits August 13, 2021 14:32
@nvliyuan nvliyuan marked this pull request as ready for review August 13, 2021 06:37
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interestingly this looks like it has been interactively edited rather than simply cherry-picked from branch-21.08. There's a number of whitespace changes and other tweaks that I would expect to have come from the original 21.08 source rather than edited here. Otherwise the docs on branch-21.08 are missing those changes, and if someone views the docs on that branch directly rather than via gh-pages they will be missing those changes.

@jlowe
Copy link
Member

jlowe commented Aug 13, 2021

this looks like it has been interactively edited

For reference, I am performing a simple diff of the docs between branch-21.08 and this PR to see this, e.g.:

$ cd src/spark-rapids
$ git fetch https://github.com/nvliyuan/spark-rapids.git gh-pages-branch-21.08
$ git diff branch-21.08 FETCH_HEAD docs

There should not be very many diffs remaining, mostly around changes for Jekyll.

@nvliyuan nvliyuan marked this pull request as draft August 14, 2021 10:01
@nvliyuan
Copy link
Collaborator Author

@jlowe yes, many of the diffs have been interactively edited. Because there are some files such as supported_ops.md which has so many diffs and it would be better to copy the file. And when I paste the code it was reformated by my IDE, so you see some whitespace. Please refer to this pr which most of the files were updated by cherry-picked. I will close this one.

@nvliyuan nvliyuan closed this Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants