Update databricks 3.0.1 shim to new ParquetFilter api #3100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
|
build |
jlowe
approved these changes
Jul 30, 2021
revans2
approved these changes
Jul 30, 2021
tgravescs
added a commit
to tgravescs/spark-rapids
that referenced
this pull request
Aug 3, 2021
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
pxLi
pushed a commit
that referenced
this pull request
Aug 4, 2021
* Update spark 301db shim to new ParquetFilter api (#3100) Signed-off-by: Thomas Graves <tgraves@nvidia.com> * Fix ParquetFilters issue (#2961) * Fix ParquetFilters issue Spark has added datetime rebase mode into constructor of ParquetFilters, see SPARK-36034, which causes the build failed. This change is adding getParquetFilters in the shim layers to match different Spark version. Signed-off-by: Bobby Wang <wbo4958@gmail.com> * Fix compiling error Co-authored-by: Bobby Wang <wbo4958@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3098
Databricks updated the api for ParquetFilters to what was in Spark 3.0.4 version. It added another parameter datetimeRebaseMode. Before this was picking up the SparkBaseShim version.
Tested manually on Databricks 7.3 runtime, all the parquet tests pass now.
Signed-off-by: Thomas Graves tgraves@nvidia.com