CreateMap support for multiple key-value pairs

docs/configs.md

@@ -65,7 +65,7 @@ Name | Description | Default Value
 <a name="sql.castStringToFloat.enabled"></a>spark.rapids.sql.castStringToFloat.enabled|When set to true, enables casting from strings to float types (float, double) on the GPU. Currently hex values aren't supported on the GPU. Also note that casting from string to float types on the GPU returns incorrect results when the string represents any number "1.7976931348623158E308" <= x < "1.7976931348623159E308" and "-1.7976931348623158E308" >= x > "-1.7976931348623159E308" in both these cases the GPU returns Double.MaxValue while CPU returns "+Infinity" and "-Infinity" respectively|false
 <a name="sql.castStringToTimestamp.enabled"></a>spark.rapids.sql.castStringToTimestamp.enabled|When set to true, casting from string to timestamp is supported on the GPU. The GPU only supports a subset of formats when casting strings to timestamps. Refer to the CAST documentation for more details.|false
 <a name="sql.concurrentGpuTasks"></a>spark.rapids.sql.concurrentGpuTasks|Set the number of tasks that can execute concurrently per GPU. Tasks may temporarily block when the number of concurrent tasks in the executor exceeds this amount. Allowing too many concurrent tasks on the same GPU may lead to GPU out of memory errors.|1
-<a name="sql.createMap.enabled"></a>spark.rapids.sql.createMap.enabled|When set to true, support the CreateMap expression on the GPU with multiple key-value pairs where the keys are not literal values. The GPU version does not detect duplicate keys or make any guarantees about which key wins if there are duplicates in this case. CreateMap is always supported on the GPU when there is a single key-value pair or when there are multiple key-value pairs with literal keys.|false
+<a name="sql.createMap.enabled"></a>spark.rapids.sql.createMap.enabled|The GPU-enabled version of the `CreateMap` expression (`map` SQL function) does not detect duplicate keys in all cases and does not guarantee which key wins if there are duplicates. When this config is set to true, `CreateMap` will be enabled to run on the GPU even when there might be duplicate keys.|false
 <a name="sql.csv.read.bool.enabled"></a>spark.rapids.sql.csv.read.bool.enabled|Parsing an invalid CSV boolean value produces true instead of null|false
 <a name="sql.csv.read.byte.enabled"></a>spark.rapids.sql.csv.read.byte.enabled|Parsing CSV bytes is much more lenient and will return 0 for some malformed values instead of null|false
 <a name="sql.csv.read.date.enabled"></a>spark.rapids.sql.csv.read.date.enabled|Parsing invalid CSV dates produces different results from Spark|false

sql-plugin/src/main/scala/com/nvidia/spark/rapids/RapidsConf.scala

@@ -638,11 +638,10 @@ object RapidsConf {
       .createWithDefault(false)
 
   val ENABLE_CREATE_MAP = conf("spark.rapids.sql.createMap.enabled")
-    .doc("When set to true, support the CreateMap expression on the GPU with multiple " +
-      "key-value pairs where the keys are not literal values. The GPU version does not detect " +
-      "duplicate keys or make any guarantees about which key wins if there are duplicates in " +
-      "this case. CreateMap is always supported on the GPU when there is a single key-value " +
-      "pair or when there are multiple key-value pairs with literal keys.")
+    .doc("The GPU-enabled version of the `CreateMap` expression (`map` SQL function) does not " +
+      "detect duplicate keys in all cases and does not guarantee which key wins if there are " +
+      "duplicates. When this config is set to true, `CreateMap` will be enabled to run on the " +
+      "GPU even when there might be duplicate keys.")
     .booleanConf
     .createWithDefault(false)
 

sql-plugin/src/main/scala/com/nvidia/spark/rapids/TypeChecks.scala

@@ -1112,7 +1112,8 @@ object CreateMapCheck extends ExprChecks {
       if (meta.childExprs.length > 2) {
         // check for duplicate keys if the keys are literal values
         val keyExprs = meta.childExprs.indices.filter(_ % 2 == 0).map(meta.childExprs)
-        if (keyExprs.forall(_.wrapped.isInstanceOf[Literal])) {
+        if (keyExprs.forall(e => GpuOverrides.extractLit(
+            e.wrapped.asInstanceOf[Expression]).isDefined)) {
           val keys = keyExprs.map(_.wrapped.asInstanceOf[Literal].value)
           val uniqueKeys = new mutable.HashSet[Any]()
           for (key <- keys) {