Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to new cudf AST API #3252

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Update to new cudf AST API #3252

merged 1 commit into from
Aug 19, 2021

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Aug 18, 2021

This updates the plugin for the breaking cudf AST API changes in rapidsai/cudf#9045. AstNode becomes AstExpression and it supports the compile() method directly. ast.Expression has been removed. ast.UnaryExpression and ast.BinaryExpression are now ast.UnaryOperation and ast.BinaryOperation, respectively.

@jlowe
Update to new cudf AST API
f1bd983 
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
@jlowe jlowe added the build Related to CI / CD or cleanly building label Aug 18, 2021
@jlowe jlowe added this to the Aug 16 - Aug 27 milestone Aug 18, 2021
@jlowe jlowe self-assigned this Aug 18, 2021
@jlowe jlowe added the cudf_dependency An issue or PR with this label depends on a new feature in cudf label Aug 18, 2021
revans2
revans2 reviewed Aug 18, 2021
View reviewed changes
Copy link
Collaborator

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Are changes going to need to be in the Spark plugin?

@jlowe
Copy link
Member Author

jlowe commented Aug 18, 2021

rapidsai/cudf#9045 just merged, so this will be ready to go after the next cudf snapshot publish.

Are changes going to need to be in the Spark plugin?

The above cudf PR made the cudf-side Java changes, and this PR covers the changes needed in the plugin.

@jlowe jlowe marked this pull request as ready for review August 18, 2021 21:55
@jlowe
Copy link
Member Author

jlowe commented Aug 18, 2021

build

@pxLi pxLi merged commit 37986e4 into NVIDIA:branch-21.10 Aug 19, 2021
razajafri pushed a commit to razajafri/spark-rapids that referenced this pull request Aug 23, 2021
@jlowe @razajafri
Update to new cudf AST API (NVIDIA#3252)
03d67f4 
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
@jlowe jlowe deleted the ast-refactor-update branch September 10, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revans2 revans2 revans2 left review comments

@rwlee rwlee rwlee approved these changes

Assignees

@jlowe jlowe

Labels
build Related to CI / CD or cleanly building cudf_dependency An issue or PR with this label depends on a new feature in cudf
Projects
None yet
Milestone
Aug 16 - Aug 27
Development

Successfully merging this pull request may close these issues.
4 participants
@jlowe @revans2 @rwlee @pxLi