Qualification tool: Report write data format and nested types #3263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
|
build |
tgravescs
reviewed
Aug 23, 2021
tools/src/main/scala/com/nvidia/spark/rapids/tool/qualification/QualOutputWriter.scala
Show resolved
Hide resolved
tools/src/main/scala/org/apache/spark/sql/rapids/tool/qualification/QualAppInfo.scala
Outdated
Show resolved
Hide resolved
tools/src/main/scala/org/apache/spark/sql/rapids/tool/qualification/QualAppInfo.scala
Outdated
Show resolved
Hide resolved
tools/src/main/scala/org/apache/spark/sql/rapids/tool/qualification/QualAppInfo.scala
Outdated
Show resolved
Hide resolved
tools/src/main/scala/org/apache/spark/sql/rapids/tool/qualification/QualAppInfo.scala
Outdated
Show resolved
Hide resolved
tools/src/main/scala/org/apache/spark/sql/rapids/tool/qualification/QualAppInfo.scala
Outdated
Show resolved
Hide resolved
tgravescs
reviewed
Aug 23, 2021
tools/src/main/scala/org/apache/spark/sql/rapids/tool/qualification/QualAppInfo.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
|
build |
|
@tgravescs, I think I have addressed all the review comments. PTAL. |
|
build |
tgravescs
reviewed
Aug 26, 2021
tools/src/main/scala/com/nvidia/spark/rapids/tool/qualification/PluginTypeChecker.scala
Outdated
Show resolved
Hide resolved
tools/src/main/scala/com/nvidia/spark/rapids/tool/qualification/PluginTypeChecker.scala
Outdated
Show resolved
Hide resolved
| val source = Source.fromResource(DEFAULT_DS_FILE) | ||
| val supportedWriteFormat = ArrayBuffer[String]() | ||
| try { | ||
| val fileContents = source.getLines().toSeq |
There was a problem hiding this comment.
we are parsing file twice, I'd say just parse it once and split read/writes into different datastructures. so remove this and update readSupportedTypeForPlugin
tools/src/main/scala/org/apache/spark/sql/rapids/tool/qualification/QualAppInfo.scala
Outdated
Show resolved
Hide resolved
tools/src/main/scala/org/apache/spark/sql/rapids/tool/qualification/QualAppInfo.scala
Outdated
Show resolved
Hide resolved
tools/src/main/scala/org/apache/spark/sql/rapids/tool/qualification/QualAppInfo.scala
Outdated
Show resolved
Hide resolved
tools/src/main/scala/org/apache/spark/sql/rapids/tool/qualification/QualAppInfo.scala
Outdated
Show resolved
Hide resolved
tools/src/main/scala/org/apache/spark/sql/rapids/tool/qualification/QualAppInfo.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
|
build |
|
there are some unit tests failing please take a look @nartal1 04:17:51 �[32mPluginTypeCheckerSuite:�[0m |
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
|
build |
tgravescs
reviewed
Aug 27, 2021
| @@ -2019,10 +2019,12 @@ object SupportedOpsForTools { | |||
| val conf = new RapidsConf(Map.empty[String, String]) | |||
| val types = TypeEnum.values.toSeq | |||
| val header = Seq("Format", "Direction") ++ types | |||
| val writeOps: Array[String] = Array.fill(18)("NA") | |||
There was a problem hiding this comment.
18 is very specific here, seems easily broken if format of that file changes.
tools/src/main/scala/com/nvidia/spark/rapids/tool/qualification/PluginTypeChecker.scala
Outdated
Show resolved
Hide resolved
tools/src/main/scala/com/nvidia/spark/rapids/tool/qualification/PluginTypeChecker.scala
Outdated
Show resolved
Hide resolved
tools/src/main/scala/org/apache/spark/sql/rapids/tool/qualification/QualAppInfo.scala
Outdated
Show resolved
Hide resolved
tools/src/main/scala/org/apache/spark/sql/rapids/tool/qualification/QualAppInfo.scala
Outdated
Show resolved
Hide resolved
tools/src/main/scala/org/apache/spark/sql/rapids/tool/qualification/QualAppInfo.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
|
build |
tgravescs
reviewed
Aug 30, 2021
tools/src/main/scala/org/apache/spark/sql/rapids/tool/qualification/QualAppInfo.scala
Outdated
Show resolved
Hide resolved
tgravescs
reviewed
Aug 30, 2021
tools/src/test/scala/com/nvidia/spark/rapids/tool/qualification/QualificationSuite.scala
Show resolved
Hide resolved
|
build |
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
|
build |
tgravescs
reviewed
Sep 3, 2021
tgravescs
reviewed
Sep 3, 2021
tools/src/test/scala/com/nvidia/spark/rapids/tool/qualification/QualificationSuite.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
|
build |
tgravescs
approved these changes
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #3045 and closes #3044.
For write data format, unsupported write data formats are reported in the csv.
For nested type, it parses the ReadSchema and identifies the nested types in the schema which is reported in the csv.