Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reference to old maven-scala-plugin #3270

Merged
merged 1 commit into from
Aug 20, 2021
Merged

Remove reference to old maven-scala-plugin #3270

merged 1 commit into from
Aug 20, 2021

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Aug 20, 2021

This removes a reference to the old maven-scala-plugin in the tools module which fixes the following warning that was being emitted during the build:

[WARNING] 
[WARNING] Some problems were encountered while building the effective model for com.nvidia:rapids-4-spark-tools_2.12:jar:21.10.0-SNAPSHOT
[WARNING] 'build.plugins.plugin.version' for org.scala-tools:maven-scala-plugin is missing. @ line 84, column 21
[WARNING] 
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING] 
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING]

@jlowe
Remove reference to old maven-scala-plugin
e88ada2 
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
@jlowe jlowe added the build Related to CI / CD or cleanly building label Aug 20, 2021
@jlowe jlowe added this to the Aug 16 - Aug 27 milestone Aug 20, 2021
@jlowe jlowe self-assigned this Aug 20, 2021
@jlowe
Copy link
Member Author

jlowe commented Aug 20, 2021

build

@jlowe jlowe merged commit 086bde5 into NVIDIA:branch-21.10 Aug 20, 2021
@jlowe jlowe deleted the fix-tools-dependency branch August 20, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nartal1 nartal1 nartal1 approved these changes

@tgravescs tgravescs tgravescs approved these changes

@revans2 revans2 revans2 approved these changes

@GaryShen2008 GaryShen2008 Awaiting requested review from GaryShen2008 GaryShen2008 is a code owner

@NvTimLiu NvTimLiu Awaiting requested review from NvTimLiu NvTimLiu is a code owner

Assignees

@jlowe jlowe

Labels
build Related to CI / CD or cleanly building
Projects
None yet
Milestone
Aug 16 - Aug 27
Development

Successfully merging this pull request may close these issues.
4 participants
@jlowe @revans2 @tgravescs @nartal1