Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for current_date, current_timestamp and now #3282

Merged
merged 2 commits into from
Aug 25, 2021

Conversation

shaneding
Copy link
Contributor

This PR closes #27. Added testcases for current_date, current_timestamp and now.

Signed-off-by: Shane Ding shane200195@gmail.com

Signed-off-by: Shane Ding <shane200195@gmail.com>
revans2
revans2 previously approved these changes Aug 24, 2021
Copy link
Collaborator

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Would be nice to have a now in there too, and have a time range of about 10 or so seconds.

Signed-off-by: Shane Ding <shane200195@gmail.com>
@revans2
Copy link
Collaborator

revans2 commented Aug 24, 2021

build

@revans2 revans2 added the test Only impacts tests label Aug 24, 2021
@revans2 revans2 added this to the Aug 16 - Aug 27 milestone Aug 24, 2021
@shaneding shaneding changed the title [WIP] test for current_date, current_timestamp and now Test for current_date, current_timestamp and now Aug 25, 2021
@revans2 revans2 merged commit 4cc1d89 into NVIDIA:branch-21.10 Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] test current_date and current_timestamp
2 participants