Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LeftAnti nested loop join missing condition case #3318

Merged
merged 2 commits into from
Aug 27, 2021

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Aug 26, 2021

Fixes #3244.

The original code was trying to return an empty batch for this degenerate case when what we really want to do is return an empty RDD (i.e.: no batches).

Signed-off-by: Jason Lowe <jlowe@nvidia.com>
@jlowe jlowe added this to the Aug 16 - Aug 27 milestone Aug 26, 2021
@jlowe jlowe self-assigned this Aug 26, 2021
abellina
abellina previously approved these changes Aug 26, 2021
Copy link
Collaborator

@abellina abellina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits from me, otherwise this works in databricks.

@jlowe
Copy link
Member Author

jlowe commented Aug 26, 2021

build

@jlowe jlowe merged commit ad5399a into NVIDIA:branch-21.10 Aug 27, 2021
@jlowe jlowe deleted the fix-bnlj-left-anti-empty branch August 27, 2021 13:58
@sameerz sameerz added the bug Something isn't working label Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] join_test LeftAnti failing on Databricks
3 participants