Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HashAggregate on struct and nested struct #3354

Merged
merged 3 commits into from
Sep 1, 2021

Conversation

sperlingxx
Copy link
Collaborator

Signed-off-by: sperlingxx lovedreamf@gmail.com

Closes #2877

Signed-off-by: sperlingxx <lovedreamf@gmail.com>
@sperlingxx
Copy link
Collaborator Author

build

@sameerz sameerz added the feature request New feature or request label Aug 31, 2021
@sameerz sameerz added this to the Aug 30 - Sept 10 milestone Aug 31, 2021
Copy link
Collaborator

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks really good. Thanks to @jlowe for reminding me about the TrampolineUtil in my other PR :)

Signed-off-by: sperlingxx <lovedreamf@gmail.com>
@sperlingxx
Copy link
Collaborator Author

build

@sperlingxx sperlingxx requested a review from revans2 September 1, 2021 02:28
@revans2 revans2 merged commit 5e02b2f into NVIDIA:branch-21.10 Sep 1, 2021
@sperlingxx sperlingxx deleted the nested_struct_hashagg branch December 2, 2021 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Support HashAggregate on struct and nested struct
3 participants