Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback to the CPU for IGNORE NULLS on lead and lag #3387

Merged
merged 4 commits into from
Sep 7, 2021
Merged

Fallback to the CPU for IGNORE NULLS on lead and lag #3387

merged 4 commits into from
Sep 7, 2021

Conversation

revans2
Copy link
Collaborator

@revans2 revans2 commented Sep 3, 2021

This fixes #1923

@revans2
Fallback to the CPU for IGNORE NULLS on lead and lag
d614792 
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
@revans2 revans2 added this to the Aug 30 - Sept 10 milestone Sep 3, 2021
@revans2 revans2 self-assigned this Sep 3, 2021
@revans2
Copy link
Collaborator Author

revans2 commented Sep 3, 2021

build

@revans2
Copy link
Collaborator Author

revans2 commented Sep 3, 2021

It should be noted that RESPECT NULLS is the default and we already support that

@revans2
Copy link
Collaborator Author

revans2 commented Sep 7, 2021

build

jlowe
jlowe previously approved these changes Sep 7, 2021
View reviewed changes
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit about some apparently unused data being generated but otherwise lgtm.

integration_tests/src/main/python/window_function_test.py Outdated
('b', b_gen),
('c', c_gen),
('d', d_gen),
('d_default', d_gen)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now seems to be unused? Also applies to the copy above.

@jlowe
Copy link
Member

jlowe commented Sep 7, 2021

build

@revans2 revans2 merged commit 8e1fd7e into NVIDIA:branch-21.10 Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

Assignees

@revans2 revans2

Labels
audit_3.2.0
Projects
None yet
Milestone
Aug 30 - Sept 10
Development

Successfully merging this pull request may close these issues.

[FEA] Fall back to the CPU when LEAD/LAG wants to IGNORE NULLS
2 participants
@revans2 @jlowe